Rails 5.2 support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aried3r
force-pushed
the
ar/rails_5.2_support
branch
from
b5a83db
to
59a3762
Compare
|
I am not entirely sure what causes the tests to fail with Rails 3.x. I know this is the easy way out, but would it be ok to drop old Rails versions for the next version of mail_form? |
tegon
reviewed
Apr 11, 2018
.travis.yml
Outdated
| - Gemfile | ||
| before_install: | ||
| - gem update --system | ||
| - gem install bundler # https://github.com/travis-ci/travis-ci/issues/9333 | ||
| matrix: | ||
| exclude: | ||
| - rvm: 2.2.9 |
|
@aried3r Looks like it's failing because you've bumped the ruby versions in the Travis build. |
|
🤦♂️ you're right, thanks! All the more reason to drop it so I can't make this mistake anymore ;) |
|
@aried3r Yeah, I think it makes sense to drop it but that's a matter for another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.