Add support for Rails 5.2 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperenan
reviewed
Apr 11, 2018
Gemfile.lock
Outdated
| @@ -2,74 +2,77 @@ PATH | |||
| remote: . | |||
| specs: | |||
| show_for (0.6.0) | |||
| actionpack (>= 4.1, < 5.2) | |||
| activemodel (>= 4.1, < 5.2) | |||
| actionpack (>= 4.1, < 6.0) | |||
There was a problem hiding this comment.
Maybe it worth remove the upper bound like we did in Simple Form. See: heartcombo/simple_form#1543 (diff)
feliperenan
reviewed
Apr 11, 2018
| - rvm: 2.1.10 | ||
| gemfile: gemfiles/Gemfile-rails.head | ||
| - rvm: 2.2.10 | ||
| gemfile: gemfiles/Gemfile-rails.4.1.x |
There was a problem hiding this comment.
Could we drop these Rails old versions? 🤔
There was a problem hiding this comment.
Maybe, but I think that's a matter for another PR. Since none of the tests broke I think we can leave as it is for now.
|
Looking forward to approval of this PR! |
|
ASAP, release a new version of gem, with the support of Rails 5.2.x. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the gem to be installed on Rails 5.2.
Closes #84