Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg file ruined #57

Closed
AmirMGhanem opened this issue Jan 6, 2023 · 8 comments
Closed

svg file ruined #57

AmirMGhanem opened this issue Jan 6, 2023 · 8 comments

Comments

@AmirMGhanem
Copy link

AmirMGhanem commented Jan 6, 2023

Can anyone tell me why i am getting as output only small piece of the snake svg ?

https://github.com/AmirMGhanem/AmirMGhanem/blob/output/github-contribution-grid-snake.svg

  • it worked before, today's workflow went like this.

@Platane

@Zxilly
Copy link

Zxilly commented Jan 6, 2023

You use Platane/snk@master, just switch it to uses: Platane/snk@main
Github just change their profile page structure. The outdated version no longer work.
You should also update your argument.

@AmirMGhanem
Copy link
Author

AmirMGhanem commented Jan 6, 2023

@Zxilly
Error: Build dir does not exist

@AmirMGhanem
Copy link
Author

AmirMGhanem commented Jan 6, 2023

BTW, @Zxilly
also yours @ https://github.com/Zxilly/Zxilly

@Zxilly
Copy link

Zxilly commented Jan 6, 2023

I just update it, it works now.
You can follow my conf.

@Platane
Copy link
Owner

Platane commented Jan 6, 2023

Thanks for the help @Zxilly

For some context, I was lazy with the versioning when I started. I did not pin the version in my workflow config.

As a lot of people copied my config, this lead to a lot of workflows automatically pulling the latest version. Which is a pain when introducing breaking changes.

When I introduced the v2 ( with breaking change ) I left the master version frozen to not impact them.

Unfortunately, today github changed the profile page markup, I fixed it on 2.2.0 . But master is frozen

@Zxilly
Copy link

Zxilly commented Jan 6, 2023

Maybe this fix can be backport to old version.

@Platane
Copy link
Owner

Platane commented Jan 6, 2023

Maybe this fix can be backport to old version.

yes, I think it needs to

@AmirMGhanem
Copy link
Author

Thank you!
works as Expected
@Zxilly

Thanks @Platane :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants