Fix nested with collection filtering #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because when we replaced select 2 with slim select, a small functionality went missing: in the
nested_select
, using thecollection
option in a level that has a parent should only include elements that belong to the selected parent when searchingDetail
This Pull Request restores that functionality, and adds a test for it. It does so by adding to every option the
id
of it's parent in an attribute with the same name as the parent, and then in thejs
it checks for options that match theparentId
of the select.Additional information
Video of the fix working
Screen.Recording.2023-04-24.at.09.27.44.mov
Checklist
Before submitting the PR make sure the following are checked: