-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observers #5
Observers #5
Conversation
Changes Unknown when pulling 62921e5 on observers into ** on master**. |
@@ -0,0 +1,5 @@ | |||
require 'rails_helper' | |||
|
|||
describe <%= class_name %>Observer do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unterminated string meets end of file
# before_create { puts "yes, you can provide a block to work with" } | ||
# | ||
# def run | ||
# p object # object holds an <%= class_name %> instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tIDENTIFIER
unterminated string meets end of file
@@ -0,0 +1,8 @@ | |||
class <%= class_name %>Observer < PowerTypes::Observer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected token tLT
@ldlsegovia como recomendacion, yo haria este PR mas chico, solo con lo de observers... Pondria en otro PR lo de travis para el release y el readme arreglado. |
@blackjid con "el readme arreglado" te referis a los badges? porque el cambio grande que hice en el README es para agregar docs sobre los observers. |
Me parecio q el readme ademas de lo de observers tenia de todoa los otros tipos, que no estaban documentados. |
So pienso q es mas facil que el asigneeo mire cuando es mas chico y acotado a lo que realmente es el pr. En este caso pixar. Lo de los linters tambien lo tiraria a otro |
me parece! |
Sobre el README, en realidad lo reesctructuré para meter lo de los observers y para facilitar el agregado de nuevos tipos. Por esto, lo dejo en el PR de observers |
No description provided.