Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Certain Use of Test Vault Causes Duplication of Linter Settings Tab #971

Closed
1 task done
pjkaufman opened this issue Dec 10, 2023 · 1 comment
Closed
1 task done
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature

Comments

@pjkaufman
Copy link
Collaborator

  • I have verified that I am on the latest version of the Linter

Describe the Bug

When using the test vault, if you have the vault running and then copy the main.js file into the obsidian-linter plugin's location after running the integration tests, it causes the Linter tab to get duplicated once hotreload runs.

How to Reproduce

Steps to reproduce the behavior:

  1. Go to the base of the repo in the terminal
  2. Run npm run dev or npm run build
  3. Open the test vault
  4. Run command for running tests ctrl+p and then the run Linter tests command
  5. Go back to the terminal and copy the main.js to the obsidian linter plugin location
  6. Wait for hotreload to run
  7. Notice that there are now two settings tabs for the Linter

I have tried looking into the issue, but so far I am not 100% certain why Obsidian is not removing one of the Linter settings tabs. I likely need to just not create the settings tab for obsidian Linter while doing tests.

@pjkaufman pjkaufman added bug Something isn't working obsidian Obsidian specific syntax issue or feature labels Dec 10, 2023
@pjkaufman
Copy link
Collaborator Author

So long as you use npm run build this is not a problem. So I am going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature
Projects
None yet
Development

No branches or pull requests

1 participant