Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle More Complex Paragraphs for Paragraph Blank Lines #252

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Handle More Complex Paragraphs for Paragraph Blank Lines #252

merged 2 commits into from
Jul 4, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #250

Added a more complex setup for handling paragraph content when trying to add blank lines before and after it.

Changes Made:

  • added several new tests for the scenarios listed in the issue and for a couple more that could have been affected by the use of the paragraph parser
  • Updated logic to replace simpler use of regex for a more complex function to handle scenarios from the issue

pjkaufman and others added 2 commits July 3, 2022 21:38
@pjkaufman
added some checks on the paragraph blank lines to make sure it would …
1c937e7 
…handle several other scenarios as pointed out in a bug ticket. It should handle the scenarios in question without breaking the previously tested scenarios
@pjkaufman
Merge branch 'platers:master' into master
8bcfeb9
@pjkaufman pjkaufman merged commit 494d164 into platers:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: paragraph-blank-lines only work on paragraphs started with English character
1 participant
@pjkaufman