Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a Couple of Regex Issues and Respecting Disabled Rules for Special Rules #310

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #306
Fixes #303
Fixes #300

Changes Made:

  • Updated the running of special rules to make sure they check if the rule is disabled before trying to run it
  • Updated regex for tail of English to Chinese to make sure a dollar sign is listed as something that needs a space after it
  • Updated regex for multiline comments to make sure it starts a line in order to be counted as something to escape to prevent single line comments from getting caught in the regex
  • Added tests to make sure we hopefully will avoid reintroducing the above problems (checking disabled rules did not have any UTs added)

@pjkaufman pjkaufman added bug Something isn't working enhancement New feature or request markdown General Markdown or Markdown related issue or feature obsidian Obsidian specific syntax issue or feature labels Jul 25, 2022
@pjkaufman pjkaufman self-assigned this Jul 25, 2022
@pjkaufman pjkaufman merged commit 319a737 into platers:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request markdown General Markdown or Markdown related issue or feature obsidian Obsidian specific syntax issue or feature
Projects
None yet
1 participant