Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Enhancement and Bug Fixes #317

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Conversation

pjkaufman
Copy link
Collaborator

Fixes #302
Fixes #301

Changes Made:

  • made sure to not wait on locale change to continue loading plugin as that is not necessary and it is almost always guaranteed to load before a user would get to the settings tab option
  • Updated debug message to make it clear that the change made only affects this plugin
  • Updated spaces between Chinese and English characters to ignore images and to only affect the contents of either bold or italics text
    • Note: that nesting of italics and bold is not currently supported
  • Added tests to help ensure that we do not accidentally reintroduce these issues down the line
  • Added helper methods to mdast
  • Added ignore types for bold and italics

@pjkaufman pjkaufman merged commit 6f3747a into platers:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Image Links with Chinese characters can cause problems Bug: When I use emphasis, there will be spaces
1 participant