Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue with Additional Angle Brackets Around URL When It Ends in #some-text-here #342

Merged
merged 3 commits into from
Aug 13, 2022
Merged

Fix Issue with Additional Angle Brackets Around URL When It Ends in #some-text-here #342

merged 3 commits into from
Aug 13, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #339

Changes Made:

  • Updated regex for tags to make sure they are only matched on if they start a line or follow some kind of whitespace
  • Added logic to remove multiple angle brackets
  • Added an example to show the addition in the logic
  • Added a UT so we hopefully do not cause the same issue down the road

@pjkaufman pjkaufman added the bug Something isn't working label Aug 13, 2022
@pjkaufman pjkaufman self-assigned this Aug 13, 2022
@pjkaufman pjkaufman changed the title Fix Issue with Additional Angle Brackets Around URL When It Ends in #some-text-here and made Fix Issue with Additional Angle Brackets Around URL When It Ends in #some-text-here Aug 13, 2022
@pjkaufman pjkaufman added the markdown General Markdown or Markdown related issue or feature label Aug 13, 2022
@pjkaufman pjkaufman merged commit 6cc0ef2 into platers:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: bar links with hash get embraced repeatedly on lint.
1 participant
@pjkaufman