Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 New Rules for Footnotes #40

Merged
merged 8 commits into from Sep 14, 2021
Merged

Add 2 New Rules for Footnotes #40

merged 8 commits into from Sep 14, 2021

Conversation

chrisgrieser
Copy link
Contributor

see issue #39. Also ran npm run compile and npm run lint this time :)

@chrisgrieser
Copy link
Contributor Author

I would have added #36 as well, but I do not know how to get the tabsize setting.

@chrisgrieser
Copy link
Contributor Author

added further exceptions for the capitalize rule

rules.ts Show resolved Hide resolved
rules.ts Show resolved Hide resolved
rules.ts Show resolved Hide resolved
rules.ts Show resolved Hide resolved
rules.ts Outdated Show resolved Hide resolved
rules.ts Show resolved Hide resolved
@platers
Copy link
Owner

platers commented Sep 13, 2021

I would have added #36 as well, but I do not know how to get the tabsize setting.

You can pass it in as an option, the user can set tabsize=2 in the settings. See the other rules for examples.

@chrisgrieser
Copy link
Contributor Author

Okay just to be sure, I took the rules.ts from your repo, redid all the necessary steps again and commited once more. I have no idea what is/was happening with those tests that changed – I literally did not touch any of those things code sections that are supposedly changed.

Anyway, this here seems to work, all tests pass when compiling, moving footnotes to the bottom does not do anything when already at the bottom. Depending on what you think about the issue with the consecutive blank lines when moving footnotes, I think this should work (other than the tests that are changed for some weird reason.)

@chrisgrieser
Copy link
Contributor Author

okay, modified the moving to bottom rule, now I think everything should be fine

@platers platers merged commit b9cef87 into platers:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants