Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap Out URL Test Regex to Make Sure Pasting URL Check Finished in Reasonable Timeframe #500

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Swap Out URL Test Regex to Make Sure Pasting URL Check Finished in Reasonable Timeframe #500

merged 2 commits into from
Nov 15, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #497

Changes Made:

  • Refactored the no bare URLs URL regex to use for both no bare URLs and for the check in the paste command logic

Note that the regex used is less robust, but it is much faster than the other one.

@pjkaufman pjkaufman added the bug Something isn't working label Nov 15, 2022
@pjkaufman pjkaufman self-assigned this Nov 15, 2022
@pjkaufman pjkaufman merged commit adaf061 into platers:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Pasting certain urls will cause it to freeze
1 participant
@pjkaufman