Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rule for Smart Versus Dumb Quotes #729

Merged
merged 4 commits into from
May 24, 2023
Merged

Conversation

pjkaufman
Copy link
Collaborator

@pjkaufman pjkaufman commented May 23, 2023

Fixes #399
Fixes #707

Changes Made:

  • Added a rule to allow the user to specify the types of single and double quotes to use in the content of a file
  • Added a function for helping count the number of instances of a substring in a string
  • Added examples of how this rule works when converting to and from smart quotes
  • Added regex for smart quotes
  • Added an ignore for Templater blocks
  • Added Google translate translations for Spanish, German, and Simplified Chinese
  • Updated error message notices to require a user's click to make them go away

@pjkaufman pjkaufman added enhancement New feature or request markdown General Markdown or Markdown related issue or feature labels May 23, 2023
@pjkaufman pjkaufman self-assigned this May 23, 2023
@pjkaufman pjkaufman marked this pull request as ready for review May 24, 2023 00:26
@pjkaufman pjkaufman merged commit 4b84387 into platers:master May 24, 2023
1 check passed
@adampetrovic
Copy link

@pjkaufman looks like 9dbef1c introduces a bug whereby all messages require a user click to dismiss the message, as opposed to just errors. It ends up causing the page to fill up with notification messages for those who have notices enabled along with lint on save.

CleanShot 2023-05-26 at 15 45 42@2x

@pjkaufman
Copy link
Collaborator Author

Thanks for pointing this out. It currently has an issue for it (#740 ). I will not be able to address this until the next release which will be at least 1 week from now.

@pjkaufman
Copy link
Collaborator Author

@pjkaufman looks like 9dbef1c introduces a bug whereby all messages require a user click to dismiss the message, as opposed to just errors. It ends up causing the page to fill up with notification messages for those who have notices enabled along with lint on save.

CleanShot 2023-05-26 at 15 45 42@2x

This should be fixed in version 1.15.2 of the Linter @adampetrovic .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request markdown General Markdown or Markdown related issue or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Suggestion: Dumb Quotes FR: Curly quotes from straight quotes
2 participants