New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an Infinite Loop for `re-index-footnotes` and `move-footnote-to-the-bottom` #785

Merged

pjkaufman merged 1 commit into platers:master from pjkaufman:master

Jul 9, 2023

Collaborator

pjkaufman commented Jul 9, 2023

Fixes #784

Changes Made:

Accounted for starting a file with a footnote reference in the while loops which was caused by the condition being greater than -1 when it should be 0 since that is the lowest valid value that we should stop looking after we find
Added a test to move-footnote-to-the-bottom to make sure the issue does not get reintroduced


          fix an infinite loop when two references to the same footnote exist w…

c3b89c4

…ith one of them starting the file

pjkaufman added bug footnote labels

pjkaufman self-assigned this

pjkaufman merged commit c5dae1f into platers:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment