Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Footnote Definitions for Paragraph Blank Lines #788

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #787

Changes Made:

  • Added a test for the scenario in question
  • Refactored the logic around the regex for a footnote definition indicator at the start of a line
  • Checked that the beginning of the first line of a paragraph is not a footnote definition

@pjkaufman pjkaufman added bug Something isn't working footnote Deals with markdown footnotes labels Jul 11, 2023
@pjkaufman pjkaufman self-assigned this Jul 11, 2023
@pjkaufman pjkaufman merged commit c6b56de into platers:master Jul 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working footnote Deals with markdown footnotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Paragraph blank lines incorrectly adding blank lines between footnotes
1 participant