Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Remove Trailing Punctuation in Header when Followed by Whitespace and Add Better Logic for Finding Folder Childer #852

Merged
merged 4 commits into from
Aug 19, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #851

Changes Made:

  • Added an example for the scenario in question
  • Refactored the logic for finding the files to lint when running the Linter on a folder to make it a little more performant and remove the need to normalize the path
  • Updated the logic for remove trailing punctuation in header to make sure that whitespace is not counted as the end of the header

@pjkaufman pjkaufman added bug Something isn't working code cleanup labels Aug 19, 2023
@pjkaufman pjkaufman self-assigned this Aug 19, 2023
@pjkaufman pjkaufman merged commit 20c0238 into platers:master Aug 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: takes two passes to remove period and trailing space in a header
1 participant