Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Settings Components to Be More Uniform #854

Merged
merged 10 commits into from
Aug 19, 2023

Conversation

pjkaufman
Copy link
Collaborator

@pjkaufman pjkaufman commented Aug 19, 2023

Fixes #581

Made the logic for creating settings more uniform in the Linter. This should help out with making general settings that are not associated with a rule.

Changes Made:

  • Converted log level from its int value to a string value to better work with other dropdowns
  • Moved the CommonStyles type to where the settings data is since that is where it belongs
  • Adding styling info for the copy option for the Linter's full text values on the debug tab to help people get a hold of their data.json and log contents
  • Added a base setting for the general types of settings that are not associated with rules
  • Added a generic dropdown option that handles enums and regular dropdown values
  • Added a generic number input setting that should handle numeric value inputs
  • Added logic to the full width text boxes for copying out their contents kind of like how github does
  • Added a generic toggle setting that should handle boolean values for general settings
  • Added 2 new svgs for the clipboard and success scenarios
  • Replaced old settings with new implementations on general and debug tabs
  • Added a way to add search info for the tabs using a generic setting to reduce the needed info to pass around
  • Added a log levels enum and a way to take strings and set the values.
  • Added a couple more helpers to nested key of for getting different types back
  • Reworked how the custom row logic works and made it look more like the native Obsidian settings
  • Revamped the folders to ignore logic to make it work just like custom commands for selecting folders

…tings work with reusable components kind of like the rules do
…r debugging settings rather than needing to manually copy and paste to help make things easier to get to
…hem kind of like how github does it and made sure it does not copy anything for empty contents
@pjkaufman pjkaufman added enhancement New feature or request code cleanup labels Aug 19, 2023
@pjkaufman pjkaufman self-assigned this Aug 19, 2023
@pjkaufman
Copy link
Collaborator Author

I am doing something a little different where I only update languages that I know, so the remainder will need to be updated/added by someone that already knows the language.

@pjkaufman pjkaufman merged commit f87535f into platers:master Aug 19, 2023
1 check passed
@pjkaufman pjkaufman deleted the settings-components branch August 19, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Folder to ignore Examples and Functional Extensions Needed
1 participant