Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add No Bare URIs option and Fix No Bare URLs Including Certain Punctuation #860

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Add No Bare URIs option and Fix No Bare URLs Including Certain Punctuation #860

merged 5 commits into from
Aug 23, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #776
Fixes #767

Changes Made:

  • Added UTs for the scenarios where certain punctuation was being allowed as part of the end of the link
  • Added a new option to No Bare URLs called No Bare URIs that will do its best to escape URIs in the format SCHEME_HERE://REST_OF_VALUE_HERE
  • Added an English and Spanish translation as they are all I know and I leave the remaining translations to contributions down the road
  • Refactored No Bare URLs logic to make it something that can be run for both regex matches
  • Made sure to ignore http, https, ftp, and smtp schemes for uri matches
  • Updated URL regex and added a simple URI regex

@pjkaufman pjkaufman added bug Something isn't working enhancement New feature or request labels Aug 23, 2023
@pjkaufman pjkaufman self-assigned this Aug 23, 2023
@pjkaufman pjkaufman merged commit 59debaf into platers:master Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: No Bare URLs include period and parenthesis at the end of the sentence. FR: No bare URIs
1 participant
@pjkaufman