Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Heading Blank Lines to Not Add Blank Line Between 2 Headings when Bottom=false #874

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #773

Changes Made:

  • Updated the logic to leave two headings that are back to back with any number of blank lines between them as they were
  • Added tests for the scenario in question

Do note that this means that if 2 headings have 5 blank lines between them and the option to add a blank line between headings is set to false, then those 5 blank lines will be left as is.

Here is what will happen in the scenario mentioned above:

# Heading 1




# Heading 2

After lint:

# Heading 1




# Heading 2

…dded when there are not two headings back to back when bottom is set to false
@pjkaufman pjkaufman added enhancement New feature or request markdown General Markdown or Markdown related issue or feature labels Sep 3, 2023
@pjkaufman pjkaufman self-assigned this Sep 3, 2023
@pjkaufman pjkaufman merged commit 20b57ab into platers:master Sep 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request markdown General Markdown or Markdown related issue or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Heading Blank Lines Rule should not insert empty lines between headings
1 participant