Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add authoring feature for Community Stories #164

Merged
merged 16 commits into from
Jul 2, 2020

Conversation

jhung
Copy link
Collaborator

@jhung jhung commented Jun 24, 2020

Description

Adds a pcc-story post type to the Admin interface and allows the authoring of content to be featured the Community Voices > Stories section of the front-end site.

To Test

  1. Activate the pcc-framework plugin with the changes from this pull request.
  2. Go to "Stories > Organization", "Stories > Region", "Stories > Sector" and add a new term to each of those taxonomies.
  3. Go to "Stories > Add new"
  4. Enter a title and a quote in the body.
  5. In the sidebar, specify a Youtube video url (ex. https://www.youtube.com/watch?v=savByUiUvbY&feature=youtu.be)
  6. Add a Featured Image
  7. Choose a Storyteller (it should be populated with names from the Persons post type)
  8. Choose a Sector, Region, and Organization (the terms you specified in step 2 should appear in these lists).
  9. Publish.

Expected behaviour

The Story content should save and be listed under "All stories".

Known issues

Currently there is no input validation. See #162 .

@jhung jhung requested a review from greatislander June 24, 2020 18:30
@greatislander greatislander added the enhancement New feature or request label Jun 25, 2020
@greatislander greatislander added this to the 2.3.0 milestone Jun 25, 2020
@greatislander greatislander changed the title Add/community voices feat: community stories backend Jun 25, 2020
@jhung jhung changed the title feat: community stories backend feat: Add authoring feature for Community Stories Jun 30, 2020
@jhung jhung marked this pull request as ready for review June 30, 2020 18:27
@jhung
Copy link
Collaborator Author

jhung commented Jun 30, 2020

There are some changes from other commits in the history. These changes need to be verified.

Also package-lock.json was modified and probably shouldn't. I can revert it, but awaiting feedback first.

Copy link
Collaborator

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me. The one change I'd recommend is adding a link below the Storyteller dropdown to add a new storyteller(/wp-admin/post-new.php?post_type=pcc-person) in case there isn't a "Person" for the storyteller.

lib/posttypes/pcc-story.php Outdated Show resolved Hide resolved
lib/posttypes/pcc-story.php Outdated Show resolved Hide resolved
pcc-framework.php Show resolved Hide resolved
@greatislander greatislander merged commit 7727a54 into platform-coop-toolkit:dev Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants