Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search bar search button #117

Closed
cherylhjli opened this issue Jan 2, 2020 · 0 comments · Fixed by #144
Closed

Search bar search button #117

cherylhjli opened this issue Jan 2, 2020 · 0 comments · Fixed by #144
Assignees
@greatislander
Labels
enhancement New feature or request
Projects
Pinecone 1.0.0 Cooperative Resource Library 1.0.0
Milestone
1.0.0-alpha.5

Comments

@cherylhjli
Copy link

Describe the bug
Search bar should have a button that triggers search upon click, so that the only trigger for search is not hitting the "enter" key.

New designers
Updated the resource library component library file, you can view the specific pages here:
https://xd.adobe.com/view/5cbb2c96-51ce-4b66-4604-15c35058ee9c-2a8a/screen/31e0fdb1-30b0-4ec3-82fa-96970d4c7c70/00-Desktop-components-10
https://xd.adobe.com/view/5cbb2c96-51ce-4b66-4604-15c35058ee9c-2a8a/screen/74ff721f-3752-4917-8820-25bfee856a0e/00-Desktop-components-11
https://xd.adobe.com/view/5cbb2c96-51ce-4b66-4604-15c35058ee9c-2a8a/screen/42cf801a-3332-4bb9-89a3-6b82a4acd073/00-Desktop-components-12
@greatislander greatislander added the enhancement New feature or request label Jan 6, 2020
@greatislander greatislander self-assigned this Jan 6, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 Jan 6, 2020
@greatislander greatislander mentioned this issue Jan 13, 2020
Closed
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 13, 2020
@greatislander greatislander moved this from To do to In progress in Pinecone 1.0.0 Jan 14, 2020
@greatislander greatislander mentioned this issue Jan 14, 2020
Merged
2 tasks
Cooperative Resource Library 1.0.0 automation moved this from To Do to Done Jan 15, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Jan 15, 2020
greatislander pushed a commit that referenced this issue Jan 15, 2020
feat: add new search bar (resolves #117) (#144)
956880b 
* feat: move search component into molecules
* feat: adjust search input style
* feat: rename inverse variant
* feat: implement states
* fix: align with WordPress search form pattern
* fix: icon alignment
* fix: align focus state with text inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.5
Development

Successfully merging a pull request may close this issue.

feat: add new search bar (resolves #117) platform-coop-toolkit/pinecone
2 participants
@greatislander @cherylhjli