Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new search bar (resolves #117) #144

Merged
merged 7 commits into from
Jan 15, 2020
Merged

feat: add new search bar (resolves #117) #144

merged 7 commits into from
Jan 15, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 14, 2020 •
edited

Description

Adds new search bar as specified in #117.

Steps to test

Review component:

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 14, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 14, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 14, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 14, 2020
@greatislander greatislander moved this from To Do to In Progress in Cooperative Resource Library 1.0.0 Jan 14, 2020
@greatislander greatislander marked this pull request as ready for review January 14, 2020 16:09
@cherylhjli
Copy link

  • Dark search bar - the search icon is a little off centre, moves a bit when its focused
  • Active/pressed state is currently the same as focus state across all browsers - can we make it just the 2px border?
  • I really like a 1px border around the field upon hover, can we actually make that behaviour consistent with the input fields?

@greatislander greatislander merged commit 956880b into dev Jan 15, 2020
Cooperative Resource Library 1.0.0 automation moved this from In Progress to Done Jan 15, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Jan 15, 2020
@greatislander greatislander deleted the add/new-search branch January 15, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylhjli cherylhjli Awaiting requested review from cherylhjli

@dayotte dayotte Awaiting requested review from dayotte

@jhung jhung Awaiting requested review from jhung

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.5
Development

Successfully merging this pull request may close these issues.

Search bar search button
2 participants
@greatislander @cherylhjli