Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve current/active/focus menu states (resolves #98) #145

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix: improve current/active/focus menu states (resolves #98) #145

merged 2 commits into from
Jan 15, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 15, 2020 •
edited
Loading

Description

Resolves ambiguity in menu states (#98).

Steps to test

Review components:

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 15, 2020
@greatislander greatislander added the bug Something isn't working label Jan 15, 2020
@greatislander greatislander added this to the 1.0.0-alpha.5 milestone Jan 15, 2020
@greatislander greatislander marked this pull request as ready for review January 15, 2020 17:22
@greatislander greatislander merged commit 2f0ecff into dev Jan 15, 2020
@greatislander greatislander deleted the fix/menu-states branch January 15, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylhjli cherylhjli cherylhjli approved these changes

@dayotte dayotte Awaiting requested review from dayotte

@jhung jhung Awaiting requested review from jhung

Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-alpha.5
Development

Successfully merging this pull request may close these issues.

Opening submenu in Menu component has misleading focus styling in mobile
2 participants
@greatislander @cherylhjli