Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language button label not being read by NVDA #174

Closed
jhung opened this issue Jan 20, 2020 · 0 comments · Fixed by #175
Closed

Language button label not being read by NVDA #174

jhung opened this issue Jan 20, 2020 · 0 comments · Fixed by #175
Assignees
@greatislander
Labels
bug Something isn't working
Projects
Pinecone 1.0.0 Cooperative Resource Library 1.0.0
Milestone
1.0.0-alpha.8

Comments

@jhung
Copy link
Contributor

jhung commented Jan 20, 2020

Describe the bug
The Language button label is not being read by NVDA. NVDA reports: "Button collapsed", but does not read the label. Did not test with other screen readers.

To Reproduce
Steps to reproduce the behavior:

  1. Launch a screen reader
  2. Go to the Menu molecule.
  3. Move focus until Language item is focused.
  4. Notice that the screen reader does not report the label of the button.

Expected behavior
Screen reader should read the label of the button when focused.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox 72.0.1
  • Screenreader: NVDA 2019.2.1

Additional context
Other screen readers may exhibit this issue, but was only tested on NVDA.
@jhung jhung added the bug Something isn't working label Jan 20, 2020
@greatislander greatislander added this to the 1.0.0-alpha.8 milestone Jan 20, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Jan 20, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 20, 2020
@greatislander greatislander self-assigned this Jan 20, 2020
@greatislander greatislander moved this from To do to In progress in Pinecone 1.0.0 Jan 20, 2020
@greatislander greatislander moved this from To Do to In Progress in Cooperative Resource Library 1.0.0 Jan 20, 2020
greatislander added a commit that referenced this issue Jan 20, 2020
@greatislander
fix: language button label not accessible to screen readers
62cd417 
Resolves #174.
@greatislander greatislander mentioned this issue Jan 20, 2020
Merged
2 tasks
@greatislander greatislander moved this from In progress to Review in progress in Pinecone 1.0.0 Jan 20, 2020
@greatislander greatislander moved this from In Progress to Review in progress in Cooperative Resource Library 1.0.0 Jan 20, 2020
@greatislander greatislander moved this from Review in progress to In progress in Cooperative Resource Library 1.0.0 Jan 22, 2020
Cooperative Resource Library 1.0.0 automation moved this from In progress to Done Jan 22, 2020
Pinecone 1.0.0 automation moved this from Review in progress to Done Jan 22, 2020
greatislander added a commit that referenced this issue Jan 22, 2020
@greatislander
fix: language button label not accessible to screen readers (#175)
c076591 
Resolves #174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.8
Development

Successfully merging a pull request may close this issue.

fix: language button label not accessible to screen readers platform-coop-toolkit/pinecone
2 participants
@jhung @greatislander