Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu button functionality #232

Closed
cherylhjli opened this issue Feb 7, 2020 · 0 comments · Fixed by #244
Closed

Menu button functionality #232

cherylhjli opened this issue Feb 7, 2020 · 0 comments · Fixed by #244
Assignees
@jhung
Labels
enhancement New feature or request
Projects
Pinecone 1.0.0 Cooperative Resource Library 1.0.0
Milestone
1.0.0-alpha.11

Comments

@cherylhjli
Copy link

Is your feature request related to a problem? Please describe.

Currently the only way to close the dropdown below the menu button (https://deploy-preview-229--pinecone.netlify.com/components/preview/menu-button.html) is to click on the menu button again. A lot of similar patterns out there also allow users to close the dropdown by clicking anywhere else on the page.

Describe the solution you'd like

Be able to close the dropdown by clicking anywhere else on the page.
@cherylhjli cherylhjli added the enhancement New feature or request label Feb 7, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 10, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Feb 10, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Feb 10, 2020
greatislander added a commit that referenced this issue Feb 13, 2020
@greatislander
fix: allow menu button to be closed by clicking elsewhere
bf871a8 
Resolves #232.
@greatislander greatislander mentioned this issue Feb 13, 2020
Merged
2 tasks
Cooperative Resource Library 1.0.0 automation moved this from To do to Done Feb 13, 2020
Pinecone 1.0.0 automation moved this from To do to Done Feb 13, 2020
greatislander pushed a commit that referenced this issue Feb 13, 2020
fix: allow menu button to be closed by clicking elsewhere (resol… (#244)
c0fde91 
Resolves #232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhung jhung

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.11
3 participants
@jhung @greatislander @cherylhjli