Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent background color at Layouts -> Home #246

Closed
erictheise opened this issue Feb 13, 2020 · 3 comments · Fixed by #247
Closed

Inconsistent background color at Layouts -> Home #246

erictheise opened this issue Feb 13, 2020 · 3 comments · Fixed by #247
Assignees
@greatislander
Labels
bug Something isn't working
Projects
Pinecone 1.0.0
Milestone
1.0.0-alpha.11

Comments

@erictheise
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

At 1024px width the dark green background color at Layouts -> Home does not extend completely to the left. Mobile view loses background color entirely.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'http://localhost:3000/components/detail/home'
  2. Fiddle with window width.
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Solid dark green background throughout.

Screenshots
If applicable, add screenshots to help explain your problem.

image

image

Desktop (please complete the following information):

  • OS: OS X
  • Browser Chrome
  • Version 80.0.3987.87
@erictheise erictheise added the bug Something isn't working label Feb 13, 2020
@greatislander
Copy link
Collaborator

@erictheise Can you reproduce this here? https://pinecone.platform.coop/components/preview/home.html

@greatislander greatislander self-assigned this Feb 13, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Feb 13, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 13, 2020
@erictheise
Copy link
Member Author

@greatislander, it is exactly the same, whether the left menu is expanded or hidden.

@greatislander
Copy link
Collaborator

Weird. Thanks for reporting.

greatislander added a commit that referenced this issue Feb 14, 2020
@greatislander
fix: prevent home page overflow issues (resolves #246)
cbe22ea
@greatislander greatislander mentioned this issue Feb 14, 2020
Merged
2 tasks
Pinecone 1.0.0 automation moved this from To do to Done Feb 14, 2020
greatislander pushed a commit that referenced this issue Feb 14, 2020
fix: home page padding and background bug (resolves #239, resolv… (#247)
d0db44b 
* fix: home feed header borders

* fix: prevent home page overflow issues (resolves #246)

* fix: home page padding (resolves #239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
Pinecone 1.0.0
  
Done
Milestone
1.0.0-alpha.11
2 participants
@erictheise @greatislander