Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying filters with top-level checkboxes cause issues #253

Closed
greatislander opened this issue Feb 19, 2020 · 0 comments · Fixed by #255
Closed

Applying filters with top-level checkboxes cause issues #253

greatislander opened this issue Feb 19, 2020 · 0 comments · Fixed by #255
Assignees
@greatislander
Labels
bug Something isn't working
Projects
Pinecone 1.0.0 Cooperative Resource Library 1.0.0
Milestone
1.0.0-alpha.11

Comments

@greatislander
Copy link
Collaborator

Describe the bug
Using hidden fields for the top-level topics (etc.) with an empty value unless checked breaks the query in WordPress by overwriting other values. We should leave the checkbox but hide it so as to ensure that it doesn't pass empty values with the form submission.

To Reproduce
Steps to reproduce the behavior:

  1. Apply filters.
  2. Observe empty values for unchecked top-level categories in query string.

Expected behavior
Query string only includes checked values.

Additional context
Not applicable.
@greatislander greatislander added the bug Something isn't working label Feb 19, 2020
@greatislander greatislander self-assigned this Feb 19, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Feb 19, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Feb 19, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 19, 2020
@greatislander greatislander moved this from To do to Review in progress in Pinecone 1.0.0 Feb 20, 2020
@greatislander greatislander moved this from Review in progress to In progress in Pinecone 1.0.0 Feb 20, 2020
greatislander added a commit that referenced this issue Feb 20, 2020
@greatislander
fix: resolve #253
9c30b8c
@greatislander greatislander mentioned this issue Feb 20, 2020
Merged
2 tasks
Cooperative Resource Library 1.0.0 automation moved this from To do to Done Feb 20, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Feb 20, 2020
greatislander pushed a commit that referenced this issue Feb 20, 2020
fix: resolve issue with nested checkboxes (resolves #253) (#255)
047b918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.11
Development

Successfully merging a pull request may close this issue.

fix: resolve issue with nested checkboxes (resolves #253) platform-coop-toolkit/pinecone
1 participant
@greatislander