Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with nested checkboxes (resolves #253) #255

Merged
merged 10 commits into from
Feb 20, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Fixes #253.

Steps to test

From the Archive layout, check the top level 'Cooperative essentials' checkbox, then 'Apply Filters'.

Expected Behavior

Query string should show the top level topic and all sub topics with no empty query values.

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Feb 20, 2020
@greatislander greatislander added the bug Something isn't working label Feb 20, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Feb 20, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Feb 20, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 20, 2020
@greatislander greatislander moved this from To do to In progress in Cooperative Resource Library 1.0.0 Feb 20, 2020
@netlify
Copy link

netlify bot commented Feb 20, 2020

Deploy preview for pinecone ready!

Built with commit dbe3012

https://deploy-preview-255--pinecone.netlify.com

Cooperative Resource Library 1.0.0 automation moved this from In progress to Reviewer approved Feb 20, 2020
Pinecone 1.0.0 automation moved this from In progress to Reviewer approved Feb 20, 2020
@greatislander greatislander merged commit 047b918 into dev Feb 20, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Feb 20, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Feb 20, 2020
@greatislander greatislander deleted the fix/filter-list branch February 20, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Applying filters with top-level checkboxes cause issues
2 participants