Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Popper to 2.x #256

Closed
greatislander opened this issue Feb 20, 2020 · 0 comments · Fixed by #282
Closed

Update Popper to 2.x #256

greatislander opened this issue Feb 20, 2020 · 0 comments · Fixed by #282
Assignees
@greatislander
Labels
enhancement New feature or request
Projects
Pinecone 1.0.0 Cooperative Resource Library 1.0.0
Milestone
1.0.0-alpha.12

Comments

@greatislander
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The Popper library which we use to position the menu attached to a menu button has received a major update, and we are now using a deprecated version.

Describe the solution you'd like

We should assess and update the version used as a dependency of the menu button component.

Describe alternatives you've considered

Not applicable.

Additional context
@greatislander greatislander added the enhancement New feature or request label Feb 20, 2020
@greatislander greatislander added this to the 1.0.0-alpha.12 milestone Feb 20, 2020
@greatislander greatislander self-assigned this Feb 20, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Feb 20, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Feb 20, 2020
greatislander added a commit that referenced this issue Mar 18, 2020
@greatislander
feat: upgrade to popper 2.x (resolves #256)
1a91377
@greatislander greatislander mentioned this issue Mar 18, 2020
Merged
2 tasks
@greatislander greatislander moved this from To do to In progress in Pinecone 1.0.0 Mar 18, 2020
Cooperative Resource Library 1.0.0 automation moved this from To do to Done Mar 26, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Mar 26, 2020
greatislander pushed a commit that referenced this issue Mar 26, 2020
feat: upgrade to popper 2.x (resolves #256) (#282)
810608a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.12
Development

Successfully merging a pull request may close this issue.

feat: upgrade to popper 2.x (resolves #256) platform-coop-toolkit/pinecone
1 participant
@greatislander