Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byline can appear inline with the resource title #257

Closed
jhung opened this issue Feb 20, 2020 · 2 comments · Fixed by #258
Closed

Byline can appear inline with the resource title #257

jhung opened this issue Feb 20, 2020 · 2 comments · Fixed by #258
Assignees
@jhung
Labels
bug Something isn't working
Projects
Pinecone 1.0.0
Milestone
1.0.0-alpha.12

Comments

@jhung
Copy link
Contributor

jhung commented Feb 20, 2020

Describe the bug
In a resource list, the resource byline can appear inline with the title in some situations (see image). The byline should appear in a separate line in all situations.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a resource listing which includes a resource with a short title (Example: "Frank Pasquale").
  2. Notice the byline appears inline with the title.

Expected behavior
The author byline should appear in a separate line from the resource title.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chromium Edge
@jhung jhung added the bug Something isn't working label Feb 20, 2020
@jhung jhung self-assigned this Feb 20, 2020
@jhung jhung added this to To do in Pinecone 1.0.0 via automation Feb 20, 2020
@jhung
Copy link
Contributor Author

jhung commented Feb 20, 2020

This issue only occurs on the home feed, specifically style .home__feed header is applying flex to the contents of the resource cards which is causing the title and byline to flex in their containers.

This effect can be seen by toggling .home__feed header { display:flex; } in the debugger.

@greatislander
Copy link
Collaborator

@jhung Can you open a PR for this?

@greatislander greatislander added this to the 1.0.0-alpha.12 milestone Feb 20, 2020
jhung added a commit that referenced this issue Feb 21, 2020
@jhung
fix: resource byline displaying inline with title
c81c8d2 
Removed .home__feed header style that was causing elements to flex and appear inline.
resolve #257
@jhung jhung mentioned this issue Feb 21, 2020
Merged
2 tasks
Pinecone 1.0.0 automation moved this from To do to Done Feb 21, 2020
greatislander added a commit that referenced this issue Feb 21, 2020
@jhung @greatislander
fix: resolve issue with byline appearing inline with resource ti… (#258)
738836b 
* fix: resource byline displaying inline with title
Removed .home__feed header style that was causing elements to flex and appear inline.
resolve #257

* fix: allow home layout to render

* fix: apply flex layout to direct descendent header

Co-authored-by: Ned Zimmerman <ned@bight.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhung jhung

Labels
bug Something isn't working
Projects
Pinecone 1.0.0
  
Done
Milestone
1.0.0-alpha.12
2 participants
@jhung @greatislander