Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try improved method for styling radio buttons and checkboxes #342

Closed
greatislander opened this issue May 12, 2020 · 0 comments · Fixed by #357
Closed

Try improved method for styling radio buttons and checkboxes #342

greatislander opened this issue May 12, 2020 · 0 comments · Fixed by #357
Assignees
@greatislander
Labels
enhancement New feature or request
Projects
Pinecone 1.0.0-beta.2
Milestone
1.0.0-beta.2

Comments

@greatislander
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently our implementation has some limits (see: #286).

Describe the solution you'd like

See checkbox and radio button styling on https://native-elements.stackblitz.io. They implement CSS-only custom checkboxes and radio buttons by setting the input to have appearance: none and using pseudo-content on the input itself as opposed to relying on an adjacent selector as we do.

Describe alternatives you've considered

Not applicable.

Additional context

Would resolve #286.
@greatislander greatislander added the enhancement New feature or request label May 12, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone May 12, 2020
@greatislander greatislander self-assigned this May 12, 2020
@greatislander greatislander removed this from the 1.0.0-beta.1 milestone May 14, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0-beta.2 via automation May 25, 2020
@greatislander greatislander added this to the 1.0.0-beta.2 milestone May 25, 2020
greatislander added a commit that referenced this issue May 26, 2020
@greatislander
feat: use appearance to style radio buttons and checkboxes
41aeb95 
Resolves #342.
@greatislander greatislander mentioned this issue May 26, 2020
Merged
3 tasks
@greatislander greatislander moved this from To do to In progress in Pinecone 1.0.0-beta.2 May 26, 2020
Pinecone 1.0.0-beta.2 automation moved this from In progress to Done May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
No open projects
Pinecone 1.0.0-beta.2
  
Done
Milestone
1.0.0-beta.2
Development

Successfully merging a pull request may close this issue.

feat: use appearance to style radio buttons and checkboxes platform-coop-toolkit/pinecone
1 participant
@greatislander