Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use appearance to style radio buttons and checkboxes #357

Merged
merged 3 commits into from
May 26, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented May 26, 2020

Description

Uses appearance: none to remove default radio button and checkbox styles instead of relying on the label being adjacent to the element.

TODO:

  • Support styling radio and checkbox labels differently from other form element labels.

Steps to test

  1. Review checkbox, custom checkbox and radio button components.

Expected behavior: They match the current styling.

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this May 26, 2020
@greatislander greatislander added the enhancement New feature or request label May 26, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0-beta.2 via automation May 26, 2020
@greatislander greatislander added this to the 1.0.0-beta.2 milestone May 26, 2020
@netlify
Copy link

netlify bot commented May 26, 2020

Deploy preview for pinecone ready!

Built with commit 3a3dc34

https://deploy-preview-357--pinecone.netlify.app

@greatislander greatislander marked this pull request as ready for review May 26, 2020 17:29
@cherylhjli
Copy link

The radio buttons look like checkboxes now o_o

@greatislander
Copy link
Collaborator Author

@cherylhjli Oops! Try again once this deploy preview builds.

Pinecone 1.0.0-beta.2 automation moved this from In progress to Reviewer approved May 26, 2020
@greatislander greatislander merged commit 06d95df into dev May 26, 2020
Pinecone 1.0.0-beta.2 automation moved this from Reviewer approved to Done May 26, 2020
@greatislander greatislander deleted the feat/flexible-inputs branch May 26, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
2 participants