Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Americanize favorite #138

Merged
merged 1 commit into from
Jan 10, 2020
Merged

fix: Americanize favorite #138

merged 1 commit into from
Jan 10, 2020

Conversation

greatislander
Copy link
Collaborator

Description

It pains me to do this, but it makes sense.

Steps to test

  1. View single resource.

Expected behavior: Favourite button now says favorite, icon filename is now favorite.svg.

Additional information

Not applicable.

Related issues

Not applicable.

@greatislander greatislander self-assigned this Jan 10, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 10, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 10, 2020
@greatislander greatislander added this to the 1.0.0-alpha.4 milestone Jan 10, 2020
@greatislander greatislander merged commit fb16eb9 into dev Jan 10, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Jan 10, 2020
@greatislander greatislander deleted the fix/rename-fav branch January 10, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant