feat: add banner brand (logo) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
moved this from To Do
to Review in progress
in Cooperative Resource Library 1.0.0
|
@greatislander the logo looks a bit small to me but I'd prefer if @cherylhjli had a look |
Cooperative Resource Library 1.0.0
automation
moved this from Review in progress
to Reviewer approved
Jan 16, 2020
jhung
approved these changes
Jan 16, 2020
Cooperative Resource Library 1.0.0
automation
moved this from Reviewer approved
to Done
Jan 16, 2020
|
agree @dayotte, could the logo be a bit bigger? Maybe 2.25x the height of the typeface? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements logo in header (banner).
Steps to test
Review components:
Additional information
Not applicable.
Related issues