Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new resource layout (resolves #238) #248

Merged
merged 6 commits into from
Feb 18, 2020
Merged

fix: new resource layout (resolves #238) #248

merged 6 commits into from
Feb 18, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Feb 14, 2020 •
edited
Loading

Description

  • Implements new layout for single resource views.
  • Adds date added to resource cards.

Steps to test

Review layout.

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Feb 14, 2020
@greatislander greatislander added the enhancement New feature or request label Feb 14, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Feb 14, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Feb 14, 2020
@greatislander greatislander moved this from To do to In progress in Cooperative Resource Library 1.0.0 Feb 14, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 14, 2020
@netlify
Copy link

netlify bot commented Feb 14, 2020 •
edited
Loading

Deploy preview for pinecone ready!

Built with commit e07e79e

https://deploy-preview-248--pinecone.netlify.com

@greatislander
Copy link
Collaborator Author

@cherylhjli Updated as per our discussion.

@greatislander greatislander mentioned this pull request Feb 15, 2020
Merged
2 tasks
@cherylhjli
Copy link

This looks great!
Tiny thing I want to try... what would the metadata minus the date added look like in dark mint 500? I wonder if it would improve the hierarchy a bit more, now that there's this much info on the card.

@greatislander
Copy link
Collaborator Author

This looks great!
Tiny thing I want to try... what would the metadata minus the date added look like in dark mint 500? I wonder if it would improve the hierarchy a bit more, now that there's this much info on the card.

Screen Shot 2020-02-18 at 10 27 46 AM

Cooperative Resource Library 1.0.0 automation moved this from In progress to Reviewer approved Feb 18, 2020
Pinecone 1.0.0 automation moved this from In progress to Reviewer approved Feb 18, 2020
@greatislander greatislander merged commit 9af8409 into dev Feb 18, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Feb 18, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Feb 18, 2020
@greatislander greatislander deleted the fix/resource-layout branch February 18, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylhjli cherylhjli cherylhjli approved these changes

@dayotte dayotte Awaiting requested review from dayotte

@jhung jhung Awaiting requested review from jhung

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.11
Development

Successfully merging this pull request may close these issues.

Resource page updated format
2 participants
@greatislander @cherylhjli