Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare desired and actual versions for preflight check #113

Open
puneetguptanitj opened this issue Sep 7, 2018 · 1 comment
Open

Compare desired and actual versions for preflight check #113

puneetguptanitj opened this issue Sep 7, 2018 · 1 comment

Comments

@puneetguptanitj
Copy link
Contributor

Currently we only have a desired version of components in machine's provider config.

      providerConfig:
        ValueFrom: null
        value:
          apiVersion: sshprovider.platform9.com/v1alpha1
          componentVersions:
            cniVersion: v0.6.0
            etcdVersion: v3.3.8
            etcdadmVersion: v0.0.3
            flannelVersion: v0.10.0
            keepalivedVersion: v2.0.4
            kubernetesVersion: 1.10.4
            nodeadmVersion: v0.0.2

While checking for version skew we therefore are comparing this "desired" version to the minimum supported upgradable version. However the correct check would be to compare against the actual version. This can be supported by having actual version information as part of machine status.
This version would be set after machine reconciliation finishes successfully.

platform9/ssh-provider#45

@puneetguptanitj
Copy link
Contributor Author

Discussed with Arun, this needs to be fixed, reopening the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants