Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define pod priority for coredns deployment #160

Open
dlipovetsky opened this issue Jan 28, 2019 · 3 comments
Open

Define pod priority for coredns deployment #160

dlipovetsky opened this issue Jan 28, 2019 · 3 comments

Comments

@dlipovetsky
Copy link
Contributor

As of 1.11, coredns is the kubeadm default. But unlike kubedns, coredns has neither pod priority nor the experimental "critical pod" annotation.

The annotation is deprecated in 1.13, and kubeadm may define pod priority for coredns in 1.14.

@dlipovetsky
Copy link
Contributor Author

@ojmhetar @sarun87 Your thoughts?

@ojmhetar
Copy link
Contributor

ojmhetar commented Feb 7, 2019

It seems that kube-dns never had the critical pod annotation, so the behavior would be consistent as 1.10? ¯\_(ツ)_/¯

An option could be to apply a patch.

I submitted kubernetes/kubernetes#73649 for the future.

@dlipovetsky
Copy link
Contributor Author

Thanks for fixing upstream.

I think it's worth patching. Just to note, I'd prefer patching from cctl, rather than nodeadm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants