-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clientset for Output CRD #9
Conversation
What does this change do? |
@CamelCaseNotation I am going to add a template for pull request. Devs forget such things when posting reviews! |
@mugdha-adhav Overall, please add unit tests. |
@CamelCaseNotation @smanpathak added the description for the PR |
- Changed copyright for logging clientset to platform9 - Modified clientset for non-namespaced resources - Removed deprecated implementations - Renamed logging interface to LoggingV1alpha1Interface and added comment - Fixed the version to v1alpha1 in the Scheme
3881c2c
to
4645c94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to submit, after fixing the failing unit test
Added subtests for each test Add check for result type Add check for output object
Description
client
packge is auto-generated using code-generatorPurpose
Testing Done