Add clientset for Output CRD #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this change do? |
@CamelCaseNotation I am going to add a template for pull request. Devs forget such things when posting reviews! |
smanpathak
suggested changes
Sep 19, 2019
|
@mugdha-adhav Overall, please add unit tests. |
@CamelCaseNotation @smanpathak added the description for the PR |
- Changed copyright for logging clientset to platform9 - Modified clientset for non-namespaced resources - Removed deprecated implementations - Renamed logging interface to LoggingV1alpha1Interface and added comment - Fixed the version to v1alpha1 in the Scheme
mugdha-adhav
force-pushed
the
private/mugdha/add-clientset
branch
from
3881c2c
to
4645c94
Compare
smanpathak
approved these changes
Sep 20, 2019
smanpathak
approved these changes
Sep 20, 2019
Added subtests for each test Add check for result type Add check for output object
smanpathak
approved these changes
Sep 23, 2019
smanpathak
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clientpackge is auto-generated using code-generatorPurpose
Testing Done