New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile issue on new environments #1013
Conversation
Hi Adrian, with the change CI fails https://github.com/Jason2866/platform-espressif32/actions/runs/4004743730 |
Hi @Jason2866 , I see from that link that it is failing only for the examples of:
The example of espidf-aws-iot is forcing to use the previous SDK so, it won't work either way with lastest version of esp-idf. The 2 examples of espidf-arduino-XX has So, seems that those examples needs some reviewing perhaps. @valeros What do you think? |
@ascillato agreed aws IoT example is out. But the other two should work. There is nothing special with. The examples are there to check the use of Arduino as a component of IDF. |
@Jason2866 Yes, when using
it gives the error:
but those 2 examples work if changing the framework to: So, without updating pyparsing, a blank project on ESP32 with esp-idf 5.0 can't compile showing the error explained in the linked issues at the OP. How can we fix the compilation for those 2 examples which use Arduino as a component of IDF? Which one is the script who do the compilation for |
The only ugly way (don't like), i see is to install the old pyparsing version when using Arduino as a component of IDF. For all other cases the new pyparsing version. |
I'm also seeing this problem in nanopb CI for two weeks now ( https://github.com/nanopb/nanopb/actions/runs/4039824116/jobs/6944916384 ) with config using only
and build in a clean, new directory with |
Probably the best to merge this PR and remove Arduino as IDF component support. Users needing Arduino as a Component of IDF can use release v5.3.0. |
Agree. @valeros Please, can you take a look into this? Thanks. |
I have run into the same issue. I have been manually replacing the pyparsing version in my penv. This would reset on clears and I would have to repeat the process. Editing the version in the espidf.py file has solved this for me. Please review this pr. |
The changes in the commit 8507dd8 work perfectly for me. Thank you so much!!!! If in platformio.ini I use: But if I use Are you planning on launching a new release for espressif32? |
This PR fixes a dependency version for pyparsing needed for compiling ESP32.
There are some reports of this and the fix was being done manually:
ImportError: cannot import name 'rest_of_line' from 'pyparsing'
#1007