Switch from pty.js to node.pty with node-pty-prebuilt

[ashthespy]

Follow up to #547

Tested working on Win10 and Atom 1.27.2 (chrome:58.0.3029.110, electron:1.7.15)

[ivankravets]

It does not work for me on Mac:

The module 'platformio-atom-ide-terminal/origin/node_modules/node-pty-prebuilt/build/Release/pty.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 57. This version of Node.js requires
NODE_MODULE_VERSION 54. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or`npm install`). Error: The module 'platformio-atom-ide-terminal/origin/node_modules/node-pty-prebuilt/build/Release/pty.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 57. This version of Node.js requires
NODE_MODULE_VERSION 54. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or`npm install`).

Are you sure that it works for you WITHOUT COMPILER?

/cc @daviwil

[ashthespy]

@ivankravets positive I don't compile anything - just installed it on a vanilla Win10 machine.
What does apm install --verbose have to say?

[ivankravets]

What does apm install --verbose have to say?

It tries to build node-pty from source files. I don't have Xcode on my machine.

[ashthespy]

Strange - given node-pty-prebuilt-v0.7.3-electron-v54-darwin-x64 exists.

[ivankravets]

Let's wait when someone will test too.

[the-j0k3r]

So were waiting for someone to test this on macOS? Currently pio is dead with atom 1.28.0 with electron 2.0.3 on Windows. @ashthespy does this work there for you?

[darron1217]

This fixed my problem :)

On Atom 1.28.0 Window 10

[the-j0k3r]

nice... if it fixes yours fixes mine also its the same bug :) #555

[darron1217]

I checked it working on Mac too
on node 8.11

[daviwil]

Hey folks, just wanted to let you know I'm working on getting node-pty-prebuilt updated to 0.7.5 and to fill in the gaps with some of the newer Node versions since the last release of prebuilds for this module in January. Will keep you posted!

[rustnnes]

@ashthespy, after change the two files described on this PR, what should I do to manage this to work?

[the-j0k3r]

@ashthespy node-pty-prebuildt 0.7.5 is out https://github.com/daviwil/node-pty-prebuilt/releases/tag/v0.7.5 thx @daviwil

[ivankravets]

@the-j0k3r without Windows binaries?

[the-j0k3r]

Ah dang spoke too soon :( @ivankravets theres no pty.js binaries for m57 anyway so we wait for @daviwil

[daviwil]

My Windows build failed, looking into it now

[ashthespy]

@rustnnes cd to the package dir and apm rebuild --verbose

[rustnnes]

Works on Windows 10 x64, atom 1.28 x64, platformio-ide-terminal 2.8.2. Thanks!

By the way…
@ashthespy, with files properly edited, should apm rebuild --verbose auto-install node-pty-prebuilt or did you have to manually install it? It worked, but only after that, using npm i node-pty-prebuilt at package dir.

[the-j0k3r]

@rustnnes I can confirm that you need node-pty-prebuilt in directory else it wont work just like that, I think this is the price of manually re-building the modules with something that wasn't installed via apm, if this PR was merged and released you would have a seamless experience and it would work out of the box.

I think its better to wait for node-pty-prebuilt 0.7.5 from @daviwil to become available in all platforms, then @ashthespy bump the package to ^0.7.5 and then with some luck @ivankravets will merge this and watch a ton of bugs disappear.

[the-j0k3r]

@ashthespy GOOD NEWS node-pty-prebuild 0.7.6 is now available with builds for all OS's and supported electron versions. https://github.com/daviwil/node-pty-prebuilt/releases/tag/v0.7.6

If you bump and rebase this PR on master now is the chance to potentially get this merged.

thanks @daviwil for latest release fresh out the press.;)

[the-j0k3r]

To save time I've rebased this branch on master and bumped node-pty-prebuilt #585

[ivankravets]

Thanks! Resolved in https://github.com/platformio/platformio-atom-ide-terminal/releases/tag/v2.9.0

Please re-test.