Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eclipse] -U in build_flags does not undefine symbols in generated project #2508

Closed
dogtopus opened this issue May 17, 2019 · 1 comment

Comments

2 participants
@dogtopus
Copy link

commented May 17, 2019

What kind of issue is this?

  • PlatformIO Core.
    If you’ve found a bug, please provide an information below.

Configuration

Operating system: Arch Linux

PlatformIO Version (platformio --version): 4.0.0a13

Description of problem

Undefining a previously defined symbol using -U does not undefine it in the generated Eclipse project file.

Steps to Reproduce

  1. Append -DA_SYMBOL -UA_SYMBOL to build_flags
  2. Run pio init --ide eclipse
  3. Open the generated .cproject file and check for Symbols option

Actual Results

A_SYMBOL still shows up.

Expected Results

A_SYMBOL should not appear in the list since it is already undefined

If problems with PlatformIO Build System:

The content of platformio.ini:

[env:uno]
platform = atmelavr
board = uno
framework = arduino
build_flags = -DA_SYMBOL -UA_SYMBOL

@ivankravets ivankravets added this to the 4.0 milestone May 23, 2019

@ivankravets ivankravets added this to To do in PlatformIO 4.0 May 23, 2019

@ivankravets ivankravets moved this from To do to In progress in PlatformIO 4.0 May 24, 2019

@ivankravets ivankravets moved this from In progress to Done in PlatformIO 4.0 May 24, 2019

@ivankravets

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Please re-test with the latest PIO Core

pio upgrade --dev

Thanks!

ivankravets added a commit that referenced this issue May 24, 2019

Fix an issue when ``-U`` in ``build_flags`` does not remove macro pre…
…viously defined via ``-D`` flag // Resolve #2508

@ivankravets ivankravets removed this from Done in PlatformIO 4.0 May 24, 2019

@ivankravets ivankravets modified the milestones: 4.0, 3.6.8 May 24, 2019

@ivankravets ivankravets added this to Done in PlatformIO 4.0 May 27, 2019

@ivankravets ivankravets added this to Done in PlatformIO 4.0 May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.