Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Don't stop piohome if not needed #2784

Closed
pfeerick opened this issue Jul 13, 2019 · 1 comment
Closed

Enhancement: Don't stop piohome if not needed #2784

pfeerick opened this issue Jul 13, 2019 · 1 comment
Milestone

Comments

@pfeerick
Copy link
Contributor

pfeerick commented Jul 13, 2019

So, on Windows (and apparently linux, although I couldn't reproduce it), it seems that if there are no updates to the core, or contrib-piohome, that the piohome server is still stopped. i.e. choosing the 'Update all' option in the VScode extension, or even running pio update --core-packages when there are no updates present will result in a Reconnecting message if the PIO Home tab is open, resulting in the user needed to close the tab, and reopen PIO Home.

Is it possible to make it so that this does not occur if no dependencies are altered/affected?

It might also be worth adding a message to the update routine to indicate that PIO Home will need to be reloaded/reopened if it was indeed running and closed, or perhaps automatically restart it if it were previously running?

shutdown_piohome_servers()

Forum ref: https://community.platformio.org/t/reconnecting-message/8654

@ivankravets ivankravets added this to the 4.0.1 milestone Jul 13, 2019
@ivankravets
Copy link
Member

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants