Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio.ini lost semicolon separated comments support #3213

Closed
dontsovcmc opened this issue Oct 31, 2019 · 3 comments
Closed

platformio.ini lost semicolon separated comments support #3213

dontsovcmc opened this issue Oct 31, 2019 · 3 comments
Labels
Milestone

Comments

@dontsovcmc
Copy link

dontsovcmc commented Oct 31, 2019

Visual studio code platformio extension lost semicolon separeted comments support.

Configuration

Home 2.3.3 Core 4.0.3
PACKAGES: toolchain-xtensa32 2.50200.80 (5.2.0), framework-arduinoespressif32 2.10004.191002 (1.0.4), tool-esptoolpy 1.20600.0 (2.6.0)
Operating system: MacOS

Description of problem

Bad content of platformio.ini:**

platform = espressif32
framework = arduino
board = esp32dev

upload_port = /dev/cu.wchusbserial1420 
upload_speed = 115200  ; раньше это компилировалось

Good:**

platform = espressif32
framework = arduino
board = esp32dev

upload_port = /dev/cu.wchusbserial1420 
; теперь комментарии должны быть на отдельной строке
upload_speed = 115200  

I think the reason is tool-scons:
tool-scons ~2.20501.7 is support semicolons

tool-scons 3.30101.0 NOT:
Error: Invalid value: 115200 ; раньше это компилировалось is not a valid integer for option upload_speed in section [env:esp32dev]

@ivankravets ivankravets added this to the 4.1.0 milestone Oct 31, 2019
@ivankravets
Copy link
Member

Thanks! Interesting bug. Python 3 has different behavior for RAW config parsing and does not handle inline comments. We will work on a fix for this.

ivankravets added a commit that referenced this issue Oct 31, 2019
@ivankravets
Copy link
Member

You can re-test with pio upgrade --dev.

@ivankravets
Copy link
Member

Resolved in 1d5d09f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants