Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo to allow proper git ssh packages #3624

Closed
wants to merge 5 commits into from
Closed

Fix typo to allow proper git ssh packages #3624

wants to merge 5 commits into from

Conversation

KK1423
Copy link

@KK1423 KK1423 commented Aug 13, 2020

Calling string.split("@",2) does not split into up to two pieces. It splits up to twice, resulting in up to three pieces. This breaks when using a package version string that includes a "@" symbol, such as git@github.com:user/repo.git in a project's configuration file.

Calling string.split("@",2) does not split into up to two pieces. It splits up to twice, resulting in up to three pieces. This breaks when using a version string that includes a "@" symbol, such as "git@github.com:user/repo.git" in a project's configuration file.
@CLAassistant
Copy link

CLAassistant commented Aug 13, 2020

CLA assistant check
All committers have signed the CLA.

@ivankravets
Copy link
Member

Could you re-test with pio upgrade --dev? We totally refactored the package management system. Thanks!

@ivankravets ivankravets added this to the 4.4.0 milestone Aug 17, 2020
@KK1423
Copy link
Author

KK1423 commented Aug 17, 2020

Fixed. It seems the issue was refactored into platformio/platform/base.py.

@ivankravets
Copy link
Member

Thanks for the confirmation! The PIO Core 4.4 is planned for release next week.

@KK1423
Copy link
Author

KK1423 commented Sep 4, 2020

@ivankravets I opened up 5.0.0 today, and this issue is still there, in platformio/platform/base.py line 97.

I should have been more precise and stated that the refactor did not fix the issue, and I just tried to fix this pr to change the appropriate file after the refactor.

@ivankravets ivankravets modified the milestones: 5.0.0, 5.0.1 Sep 4, 2020
ivankravets added a commit that referenced this pull request Sep 4, 2020
@ivankravets
Copy link
Member

Sorry, finally fixed! Please re-test with pio upgrade --dev.

@rg2k
Copy link

rg2k commented Sep 6, 2020

I still seem to have an issue when using a specific branch of the ESP32 Ardunio/ESPIF framework:

platform_packages = framework-arduinoespressif32 @ https://github.com/espressif/arduino-esp32.git#idf-release/v4.0

I am running core 5.0.1a1

@ivankravets
Copy link
Member

It works for me with this configuration

[env:esp32dev]
platform = espressif32
board = esp32dev
framework = arduino
platform_packages =
  framework-arduinoespressif32 @ https://github.com/espressif/arduino-esp32.git#idf-release/v4.0

Screen Shot 2020-09-06 at 17 45 32

@ivankravets
Copy link
Member

Screen Shot 2020-09-06 at 17 47 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants