Fix network storage build support on windows #4106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns a normalized absolutized version of the pathname, whereas realpath just parses through symbolic links to paths, which can break when \\networkpath\work is mapped to X: or any other drive letter on windows
|
Fixes issue #4099 |
|
Thanks for the PR! Resolved in 4687665 Please re-test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realpath and abspath are only interchangable on unix OS's.
abspath returns a normalized absolutized version of the pathname, whereas realpath just parses through symbolic links to paths.
This breaks when \networkpath\work is mapped to X: or any other drive letter on windows but as all paths work the same under all unix based OS's, it is unaffected.