New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing library priority #55

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@MrCustomizer

MrCustomizer commented Jan 24, 2015

It seems, that the order, in which libraries are passed to Scons, is relevant. The current order has the following disadvantage: If there are two versions of the same library, one located in lib_dir and one located in the platform directory, the library in the platform directory has precedence over the library in lib_dir (at least on my system). I think it should be exactly the other way round.

An example:
We use a modified version of the library SoftwareSerial and have placed the modified version in lib_dir, which resides in our project repository. The original version of SoftwareSerial is still present in /usr/share/arduino/libraries, which is the platform lib directory. When we build our project, the modified version of SoftwareSerial should be used, not the original one.

My proposal for a solution:
Switch the order, in which the library paths are passed to Scons. This works on my Linux and Windows system. But I'm not sure, if this change can have other side effects. What is your opinion?

@aphelps

This comment has been minimized.

aphelps commented Jan 25, 2015

Yeah, agree that it would be better for local versions to override the platform default.

ivankravets added a commit that referenced this pull request Jan 29, 2015

@ivankravets

This comment has been minimized.

Member

ivankravets commented Jan 29, 2015

@MrCustomizer can you retest it with the latest develop?

$ pip uninstall platformio
$ pip install https://github.com/ivankravets/platformio/archive/develop.zip

Thanks a lot!

@MrCustomizer

This comment has been minimized.

MrCustomizer commented Jan 29, 2015

Thank you so much! I've tested it on Linux and Windows and it's working on both systems.

@ivankravets ivankravets added the bug label Jan 29, 2015

@ivankravets ivankravets added this to the 0.11.0 milestone Jan 29, 2015

@ivankravets ivankravets self-assigned this Jan 29, 2015

@ivankravets ivankravets modified the milestones: 0.11.0, 1.0.0 Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment