Skip to content
This repository has been archived by the owner on Feb 13, 2020. It is now read-only.

add prusa rambo #22

Merged
merged 1 commit into from Sep 5, 2019
Merged

Conversation

bgiot
Copy link
Contributor

@bgiot bgiot commented Sep 1, 2019

Add support for building prusa firmwares

@bgiot
Copy link
Contributor Author

bgiot commented Sep 4, 2019

@ivankravets @valeros @rafacouto @johnduhart any news ?

Copy link
Member

@ivankravets ivankravets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivankravets ivankravets requested review from ivankravets and removed request for valeros September 4, 2019 09:31
@bgiot
Copy link
Contributor Author

bgiot commented Sep 4, 2019

As defined in the prusa_rambo.json (see PR platformio/platform-atmelavr#163), we use the default variant for rambo, and the existing arduino cores. is it an issue ?

@ivankravets
Copy link
Member

I see, what to do with libraries? Where is the source code of this core?

@bgiot
Copy link
Contributor Author

bgiot commented Sep 4, 2019

Sorry, I don't think I understand your question... when building the Prusa Firmware, I use this:
platform = atmelavr
board = prusa_rambo
framework = arduino
You can check my platformio.ini at https://github.com/bgiot/Prusa-Firmware/blob/BMGCustom/platformio.ini

@ivankravets
Copy link
Member

Where did get source code for this prusa_rambo core?

@bgiot
Copy link
Contributor Author

bgiot commented Sep 4, 2019

from Prusa github: https://github.com/prusa3d/Arduino_Boards
The only modification from reprap_rambo is in the wiring.c file I think.

@bgiot
Copy link
Contributor Author

bgiot commented Sep 5, 2019

Maybe I can explain the all story, so you understand why my PR.
Up to version 3.7.x of the Prusa 3D printer firmware, I was able to compile it with platform.io with the following config:
platform = atmelavr
board = reprap_rambo
framework = arduino
With the up-coming 3.8 versions, there is an issue because Prusa has modified one of the TIMER0, and we have a conflict with the one defined by arduino core.
so I did the minimal changes in platform.io packages/platforms to be able to compile the new firmware. This implies a new board definition and a new 'core' that I called 'prusa_rambo'.

@ivankravets ivankravets removed their request for review September 5, 2019 07:54
@ivankravets ivankravets merged commit 20bccf6 into platformio:master Sep 5, 2019
ivankravets added a commit that referenced this pull request Sep 5, 2019
@bgiot
Copy link
Contributor Author

bgiot commented Sep 5, 2019

Thank you. Will test.

@bgiot
Copy link
Contributor Author

bgiot commented Sep 5, 2019

Successful test with platform upstream (https://github.com/platformio/platform-atmelavr.git)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants