Merge 1dfc428 into 1c5935b

platinumazure · Jun 27, 2023 · 6930715 · 6930715
2 parents 1c5935b + 1dfc428
commit 6930715
Show file tree

Hide file tree

Showing 20 changed files with 2,096 additions and 9,398 deletions.
diff --git a/lib/rules/assert-args.js b/lib/rules/assert-args.js
@@ -48,13 +48,13 @@ module.exports = {
         function getAssertContext() {
             assert.ok(testStack.length);
 
-            return testStack[testStack.length - 1].assertContextVar;
+            return testStack.at(-1).assertContextVar;
         }
 
         function checkAssertArity(callExpressionNode) {
             const allowedArities = utils.getAllowedArities(callExpressionNode.callee, getAssertContext()),
                 assertArgs = callExpressionNode.arguments,
-                lastArg = assertArgs[assertArgs.length - 1],
+                lastArg = assertArgs.at(-1),
                 mayHaveMessage = lastArg && isPossibleMessage(lastArg);
 
             const definitelyTooFewArgs = allowedArities.every(function (arity) {

diff --git a/lib/rules/literal-compare-order.js b/lib/rules/literal-compare-order.js
@@ -48,7 +48,7 @@ module.exports = {
         function getAssertContext() {
             assert.ok(testStack.length);
 
-            return testStack[testStack.length - 1].assertContextVar;
+            return testStack.at(-1).assertContextVar;
         }
 
         function checkLiteralCompareOrder(args, compareActualFirst) {

diff --git a/lib/rules/no-assert-equal-boolean.js b/lib/rules/no-assert-equal-boolean.js
@@ -36,7 +36,7 @@ module.exports = {
         function getCurrentAssertContextVariable() {
             assert(testStack.length, "Test stack should not be empty");
 
-            return testStack[testStack.length - 1].assertVar;
+            return testStack.at(-1).assertVar;
         }
 
         // Check for something like `equal(...)` without assert parameter.

diff --git a/lib/rules/no-assert-equal.js b/lib/rules/no-assert-equal.js
@@ -48,7 +48,7 @@ module.exports = {
         function getCurrentAssertContextVariable() {
             assert(testStack.length, "Test stack should not be empty");
 
-            return testStack[testStack.length - 1].assertVar;
+            return testStack.at(-1).assertVar;
         }
 
         function isAssertEqual(calleeNode) {

diff --git a/lib/rules/no-assert-logical-expression.js b/lib/rules/no-assert-logical-expression.js
@@ -56,7 +56,7 @@ module.exports = {
             let result = null;
 
             if (testStack.length > 0) {
-                result = testStack[testStack.length - 1].assertContextVar;
+                result = testStack.at(-1).assertContextVar;
             }
 
             return result;

diff --git a/lib/rules/no-async-in-loops.js b/lib/rules/no-async-in-loops.js
@@ -31,7 +31,7 @@ module.exports = {
             assertVariableStack = [];
 
         function isAsyncCallExpression(node) {
-            const assertContextVar = assertVariableStack[assertVariableStack.length - 1];
+            const assertContextVar = assertVariableStack.at(-1);
             return utils.isAsyncCallExpression(node, assertContextVar);
         }
 
@@ -65,7 +65,7 @@ module.exports = {
 
             /* istanbul ignore else: correctly returning undefined */
             if (isAsyncCallExpression(node)) {
-                const assertContextVar = assertVariableStack[assertVariableStack.length - 1];
+                const assertContextVar = assertVariableStack.at(-1);
                 callType = `${assertContextVar}.async()`;
             } else if (utils.isStop(node.callee)) {
                 callType = "stop()";
@@ -77,7 +77,7 @@ module.exports = {
         }
 
         function reportError(node) {
-            const loopNode = loopStack[loopStack.length - 1],
+            const loopNode = loopStack.at(-1),
                 loopType = loopNode.type;
 
             context.report({

diff --git a/lib/rules/no-compare-relation-boolean.js b/lib/rules/no-compare-relation-boolean.js
@@ -41,7 +41,7 @@ module.exports = {
         function shouldCheckArguments(calleeNode) {
             assert.ok(testStack.length);
 
-            const assertContextVar = testStack[testStack.length - 1].assertContextVar;
+            const assertContextVar = testStack.at(-1).assertContextVar;
 
             return utils.isAssertion(calleeNode, assertContextVar) && utils.isComparativeAssertion(calleeNode, assertContextVar);
         }

diff --git a/lib/rules/no-conditional-assertions.js b/lib/rules/no-conditional-assertions.js
@@ -74,7 +74,7 @@ module.exports = {
         }
 
         function isAssertion(calleeNode) {
-            const assertContextVar = testStack[testStack.length - 1].assertContextVar;
+            const assertContextVar = testStack.at(-1).assertContextVar;
             return utils.isAssertion(calleeNode, assertContextVar);
         }
 

diff --git a/lib/rules/no-early-return.js b/lib/rules/no-early-return.js
@@ -74,7 +74,7 @@ module.exports = {
                 if (utils.isTest(node.callee)) {
                     assertContextVar = utils.getAssertContextNameForTest(node.arguments);
                 } else if (utils.isAssertion(node.callee, assertContextVar) && functionScopes.length > 0) {
-                    functionScopes[functionScopes.length - 1].returnAndAssertNodes.push(node);
+                    functionScopes.at(-1).returnAndAssertNodes.push(node);
                 }
             },
 
@@ -84,7 +84,7 @@ module.exports = {
 
             "ReturnStatement": function (node) {
                 if (functionScopes.length > 0) {
-                    functionScopes[functionScopes.length - 1].returnAndAssertNodes.push(node);
+                    functionScopes.at(-1).returnAndAssertNodes.push(node);
                 }
             },
 

diff --git a/lib/rules/no-hooks-from-ancestor-modules.js b/lib/rules/no-hooks-from-ancestor-modules.js
@@ -89,7 +89,7 @@ module.exports = {
                     moduleStackInfo.hookIdentifierName = hooksParam ? hooksParam.name : null;
                     moduleStack.push(moduleStackInfo);
                 } else if (isHookInvocation(node)) {
-                    const containingModuleInfo = moduleStack[moduleStack.length - 1];
+                    const containingModuleInfo = moduleStack.at(-1);
                     const expectedHooksIdentifierName = containingModuleInfo.hookIdentifierName;
                     const usedHooksIdentifierName = node.callee.object.name;
                     const invokedMethodName = node.callee.property.name;

diff --git a/lib/rules/no-identical-names.js b/lib/rules/no-identical-names.js
@@ -59,15 +59,15 @@ module.exports = {
         }
 
         function getCurrentModuleNode() {
-            const parentModule = mapModuleNodeToInfo.get(modulesStack[modulesStack.length - 1]);
+            const parentModule = mapModuleNodeToInfo.get(modulesStack.at(-1));
             if (parentModule.modules.length > 0) {
                 // Find the last test-less module at the current level if one exists, i.e: module('foo');
                 const lastTestLessModule = findLast(parentModule.modules, node => !mapModuleNodeToInfo.get(node).hasNestedTests);
                 if (lastTestLessModule) {
                     return lastTestLessModule;
                 }
             }
-            return modulesStack[modulesStack.length - 1];
+            return modulesStack.at(-1);
         }
 
         function handleTestNames(node) {
@@ -96,7 +96,7 @@ module.exports = {
         function handleModuleNames(node) {
             if (utils.isModule(node.callee)) {
                 const title = node.arguments[0].value;
-                const currentModuleNode = modulesStack[modulesStack.length - 1];
+                const currentModuleNode = modulesStack.at(-1);
                 const currentModuleInfo = mapModuleNodeToInfo.get(currentModuleNode);
 
                 // Check if we have seen the same title in a sibling module.
@@ -149,7 +149,7 @@ module.exports = {
             },
 
             "CallExpression:exit": function (node) {
-                if (modulesStack.length > 0 && modulesStack[modulesStack.length - 1] === node) {
+                if (modulesStack.length > 0 && modulesStack.at(-1) === node) {
                     // Exiting a module so pop it from the stack.
                     modulesStack.pop();
 

diff --git a/lib/rules/no-negated-ok.js b/lib/rules/no-negated-ok.js
@@ -49,7 +49,7 @@ module.exports = {
 
             /* istanbul ignore else: correctly returns null */
             if (asyncStateStack.length > 0) {
-                result = asyncStateStack[asyncStateStack.length - 1].assertContextVar;
+                result = asyncStateStack.at(-1).assertContextVar;
             }
 
             return result;

diff --git a/lib/rules/no-ok-equality.js b/lib/rules/no-ok-equality.js
@@ -50,7 +50,7 @@ module.exports = {
         const NEGATIVE_ASSERTIONS = new Set(["notOk", "false"]);
 
         function getAssertContextVar() {
-            const state = asyncStateStack[asyncStateStack.length - 1];
+            const state = asyncStateStack.at(-1);
             return state && state.assertContextVar;
         }
 

diff --git a/lib/rules/no-qunit-start-in-tests.js b/lib/rules/no-qunit-start-in-tests.js
@@ -60,7 +60,7 @@ module.exports = {
                 if (utils.isTest(node.callee)) {
                     contextStack.push("test");
                 } else if (contextStack.length > 0 && isQUnitStart(node.callee)) {
-                    const currentContext = contextStack[contextStack.length - 1];
+                    const currentContext = contextStack.at(-1);
 
                     context.report({
                         node: node,

diff --git a/lib/rules/no-throws-string.js b/lib/rules/no-throws-string.js
@@ -18,7 +18,7 @@ const assert = require("assert"),
 function getAssertVar(testStack) {
     assert.ok(testStack && testStack.length > 0);
 
-    return testStack[testStack.length - 1].assertVar;
+    return testStack.at(-1).assertVar;
 }
 
 function isThrows(calleeNode, assertVar) {

diff --git a/lib/rules/require-object-in-propequal.js b/lib/rules/require-object-in-propequal.js
@@ -38,7 +38,7 @@ module.exports = {
         function getCurrentAssertContextVariable() {
             assert(testStack.length, "Test stack should not be empty");
 
-            return testStack[testStack.length - 1].assertVar;
+            return testStack.at(-1).assertVar;
         }
 
         function isGlobalPropEqual(calleeNode) {

diff --git a/lib/rules/resolve-async.js b/lib/rules/resolve-async.js
@@ -34,14 +34,14 @@ module.exports = {
         const asyncStateStack = [];
 
         function isAsyncCallExpression(callExpressionNode) {
-            const asyncState = asyncStateStack[asyncStateStack.length - 1];
+            const asyncState = asyncStateStack.at(-1);
             const assertContextVar = asyncState && asyncState.assertContextVar;
 
             return utils.isAsyncCallExpression(callExpressionNode, assertContextVar);
         }
 
         function getAsyncCallbackVarOrNull(calleeNode) {
-            const asyncState = asyncStateStack[asyncStateStack.length - 1];
+            const asyncState = asyncStateStack.at(-1);
             let result = null;
 
             if (asyncState) {
@@ -62,14 +62,14 @@ module.exports = {
         }
 
         function incrementSemaphoreCount(amount) {
-            const asyncState = asyncStateStack[asyncStateStack.length - 1];
+            const asyncState = asyncStateStack.at(-1);
             if (asyncState) {
                 asyncState.stopSemaphoreCount += amount;
             }
         }
 
         function addAsyncCallbackVar(lhsNode) {
-            const asyncState = asyncStateStack[asyncStateStack.length - 1];
+            const asyncState = asyncStateStack.at(-1);
 
             /* istanbul ignore else: will correctly do nothing */
             if (asyncState) {
@@ -78,7 +78,7 @@ module.exports = {
         }
 
         function markAsyncCallbackVarCalled(name) {
-            const asyncState = asyncStateStack[asyncStateStack.length - 1];
+            const asyncState = asyncStateStack.at(-1);
 
             /* istanbul ignore else: will correctly do nothing */
             if (asyncState) {

diff --git a/lib/utils.js b/lib/utils.js
@@ -276,7 +276,7 @@ exports.createAssertionCheck = function (assertions, errorMessageConfig) {
         function getCurrentAssertContextVariable() {
             assert(testStack.length, "Test stack should not be empty");
 
-            return testStack[testStack.length - 1].assertVar;
+            return testStack.at(-1).assertVar;
         }
 
         function isMethodCalledOnLocalAssertObject(calleeNode) {