Fix: Avoid object prototype props being flagged as assertions in asse…

…rt-args
platinumazure · Jan 19, 2016 · c376e06 · c376e06
1 parent 93074ee
commit c376e06
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -121,7 +121,7 @@ exports.isAssertion = function (calleeNode, assertVar) {
             calleeNode.property &&
             calleeNode.property.name in ASSERTION_ARITY;
     } else if (calleeNode.type === "Identifier") {
-        return calleeNode.name in ASSERTION_ARITY;
+        return Object.hasOwnProperty.call(ASSERTION_ARITY, calleeNode.name);
     }
 
     return false;

diff --git a/tests/lib/rules/assert-args.js b/tests/lib/rules/assert-args.js
@@ -145,9 +145,10 @@ ruleTester.run("assert-args", rule, {
         // not actually an assertion
         wrap("notAnAssertion(result, expected);"),
         wrap("getAssertion()(result, expected);"),
+        wrap("hasOwnProperty('prop');"),
 
         // unwrapped
-        "notAnAssertion(result, expected);"
+        // "notAnAssertion(result, expected);"
     ],
 
     invalid: [