Update: no-identical-names message references line number (fixes #62)

platinumazure · May 8, 2017 · f27a36c · f27a36c
1 parent f503cd0
commit f27a36c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 13 deletions.
diff --git a/lib/rules/no-identical-names.js b/lib/rules/no-identical-names.js
@@ -25,7 +25,7 @@ module.exports = {
 
     create: function (context) {
         const moduleNames = [];
-        let testNames = [];
+        const testNames = [];
 
         //----------------------------------------------------------------------
         // Helper functions
@@ -37,25 +37,39 @@ module.exports = {
 
         function handleTestNames(node, title) {
             if (utils.isTest(node.callee)) {
-                if (testNames.indexOf(title) !== -1) {
+                const duplicateTestTitle = testNames.find(t => t.title === title);
+
+                if (duplicateTestTitle) {
                     context.report({
                         node: node.arguments[0],
-                        message: "Test name is used multiple times in the same module."
+                        message: "Test name is used on line {{ line }} in the same module.",
+                        data: duplicateTestTitle
                     });
                 }
-                testNames.push(title);
+
+                testNames.push({
+                    title,
+                    line: node.arguments[0].loc.start.line
+                });
             }
         }
 
         function handleModuleNames(node, title) {
             if (utils.isModule(node.callee)) {
-                if (moduleNames.indexOf(title) !== -1) {
+                const duplicateModuleTitle = moduleNames.find(t => t.title === title);
+
+                if (duplicateModuleTitle) {
                     context.report({
                         node: node.arguments[0],
-                        message: "Module name is used multiple times."
+                        message: "Module name is used on line {{ line }}.",
+                        data: duplicateModuleTitle
                     });
                 }
-                moduleNames.push(title);
+
+                moduleNames.push({
+                    title,
+                    line: node.arguments[0].loc.start.line
+                });
             }
         }
 
@@ -66,7 +80,7 @@ module.exports = {
         return {
             "CallExpression": function (node) {
                 if (utils.isModule(node.callee)) {
-                    testNames = [];
+                    testNames.length = 0;
                 }
 
                 if (!isFirstArgLiteral(node)) {

diff --git a/tests/lib/rules/no-identical-names.js b/tests/lib/rules/no-identical-names.js
@@ -78,7 +78,7 @@ ruleTester.run("no-identical-title", rule, {
                 "test(\"it1\", function() {});"
             ].join("\n"),
             errors: [{
-                message: "Test name is used multiple times in the same module.",
+                message: "Test name is used on line 2 in the same module.",
                 column: 6,
                 line: 3
             }]
@@ -89,7 +89,7 @@ ruleTester.run("no-identical-title", rule, {
                 "test(\"it1\", function() {});"
             ].join("\n"),
             errors: [{
-                message: "Test name is used multiple times in the same module.",
+                message: "Test name is used on line 1 in the same module.",
                 column: 6,
                 line: 2
             }]
@@ -102,7 +102,7 @@ ruleTester.run("no-identical-title", rule, {
                 "});"
             ].join("\n"),
             errors: [{
-                message: "Test name is used multiple times in the same module.",
+                message: "Test name is used on line 2 in the same module.",
                 column: 8,
                 line: 3
             }]
@@ -113,7 +113,7 @@ ruleTester.run("no-identical-title", rule, {
                 "module(\"module1\");"
             ].join("\n"),
             errors: [{
-                message: "Module name is used multiple times.",
+                message: "Module name is used on line 1.",
                 column: 8,
                 line: 2
             }]
@@ -125,7 +125,7 @@ ruleTester.run("no-identical-title", rule, {
                 "module(\"module1\");"
             ].join("\n"),
             errors: [{
-                message: "Module name is used multiple times.",
+                message: "Module name is used on line 1.",
                 column: 8,
                 line: 3
             }]